Repository navigation
Adding the possibility to drive a stepper motor - #5
Conversation
|
Hi @jerlfan , there was already a branch (the main one actually) called 5.x that implemented the pyproject layout. Could you check/change your PR to use this one as the base branch (see the edit tab on right top of your PR) |
|
@jerlfan could you try and do what I proposed? |
|
Hello Sébastien, Done: I rebuilt the branch on top of 5.0.x, keeping only the stepper motor additions (arduino_telemetrix.py, config_template.toml and the new daq_move_StepperMotor.py). The actuator now follows the PyMoDAQ 5 interface (DataActuator, per-axis units and epsilons), which also fixes the two known issues listed above: the default unit and move_home not updating the position. check_plugin reports it as OK, and the unit is correctly displayed. I have not been able to test it on the hardware yet, so I converted the PR to draft. I will test it with the Arduino and mark it as ready for review afterwards. Thanks! Note: check_plugin still reports a few warnings on files I did not touch (daq_move_LED, daq_move_LEDwithLCD, daq_move_Servo, color_synthesizer, and extensions = false in pyproject.toml while the package has code in extensions). I left them out of this PR to keep it focused on the stepper motor. |
|
Tested on the hardware (Arduino Uno with a NEMA17 motor): initialization, absolute and relative moves, and homing all work, and the position is correctly updated. The PR is ready for review. |
seb5g
left a comment
There was a problem hiding this comment.
Pretty good stuff! Some remarks on the syntax. One question on the async possibilities (always good to be able to stop a motor in case it may crash into somethng...)
To be improved:
Known issue: